Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mousebender files to the _vendored/ directory #185

Merged

Conversation

agriyakhetarpal
Copy link
Member

Description

This PR moves the mousebender adaptation to the vendored/ directory, as a follow-up PR to #178, as requested in #178 (comment).

@agriyakhetarpal
Copy link
Member Author

agriyakhetarpal commented Jan 29, 2025

Should micropip/_vendored/mousebender/ contain an __init__.py file? My opinion is that it shouldn't, as we won't expect anyone to use import micropip._vendored.mousebender in their scripts, but we had micropip/externals/__init__.py so it would have been possible to use import micropip.externals prior to this PR.

I checked https://github.com/search?q=micropip.externals&type=code and the results are either not relevant or are really old, from forks that have not been updated (when micropip existed in the Pyodide repository and we included micropip.externals._pip).

@agriyakhetarpal agriyakhetarpal added this to the 0.9.0 milestone Jan 29, 2025
@hoodmane
Copy link
Member

Thanks!

@agriyakhetarpal
Copy link
Member Author

Thanks for the review!

@agriyakhetarpal agriyakhetarpal merged commit 4728a85 into pyodide:main Jan 29, 2025
8 checks passed
@agriyakhetarpal agriyakhetarpal deleted the move/external-to-vendored branch January 29, 2025 20:41
@ryanking13
Copy link
Member

Thanks Agriya!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants