-
Notifications
You must be signed in to change notification settings - Fork 56
Enable XSPICE support in libngspice #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ryanking13
merged 3 commits into
pyodide:main
from
pepijndevos:claude/libngspice-xspice-build-01DcMmL97gGrf9Cfr4s9T24p
Nov 25, 2025
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
packages/libngspice/patches/0003-fix-verilog-install-hook.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| diff --git a/src/xspice/verilog/Makefile.am b/src/xspice/verilog/Makefile.am | ||
| index 1234567..abcdefg 100644 | ||
| --- a/src/xspice/verilog/Makefile.am | ||
| +++ b/src/xspice/verilog/Makefile.am | ||
| @@ -45,9 +45,11 @@ endif | ||
| # On Windows, the dummy libvvp.* files are removed also. | ||
|
|
||
| install-exec-hook: | ||
| cd $(DESTDIR)$(pkglibdir); \ | ||
| rm -f ivlng*a libvvp* ; \ | ||
| - mv ivlngvpi.* ivlng.vpi | ||
| + if [ -f ivlngvpi.so ] || [ -f ivlngvpi.dll ] || [ -f ivlngvpi.dylib ]; then \ | ||
| + mv ivlngvpi.* ivlng.vpi; \ | ||
| + fi | ||
|
|
||
| uninstall-hook: | ||
| rm -f $(DESTDIR)$(pkglibdir)/ivlng.vpi $(DESTDIR)$(pkglibdir)/ivlng.so |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some environments (e.g. pyodide venv) we don't install shared libraries to /usr/lib as it actually points the native directory, but I guess it should be okay for unit test.