Skip to content

Add Apache Airflow to users of Hatch - #1209

Merged
ofek merged 3 commits into
pypa:masterfrom
potiuk:add-apache-airflow
Jan 21, 2024
Merged

ofek merged 3 commits into
pypa:masterfrom
potiuk:add-apache-airflow

Conversation

@potiuk

@potiuk potiuk commented Jan 13, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread docs/community/users.md Outdated

@ofek ofek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I don't know how I missed that one.

@potiuk

potiuk commented Jan 13, 2024 •

Copy link
Copy Markdown
Contributor Author

Thank you! I don't know how I missed that one.

Well. You have not ... We just switched to Hatch last week :) with this GIANT PR of mine apache/airflow#36537.

We had some REALLY complex setup and monorepo (I also commented in #233 (comment)) - it now works nicely with the variant of monorepo we currently have. This is done via some smart pre-commit integration (that automatically generates part of our pyproject.toml), custom description of our monorepo provider packages (almost 90 of those), namespace packages and on-the-flight manipulating the "standard" wheel dependencies. We dynamically replace the editable dependencies of other monorepo packages we have in pyproject.toml with the actual depenendencies to the packages themselves - I described the gist of it in #588 (comment).

I am actuallly VERY happy with what Hatch and Hatchling (both) give us in Airflow.

But I would love to cooperate in the future and help to figure out a more "proper" monorepo support - maybe involving some way of merging pyproject.toml and editable paths between the monoreps (as I described in #233 (comment)) - And I came to think that maybe it will need some PEP to describe it before Hatch implements it.

I'd love to hear your thoughts.

Airflow might be great testing ground for it (especially now where Hatch/Hatchling are so nicely integrated).

@potiuk

potiuk commented Jan 21, 2024

Copy link
Copy Markdown
Contributor Author

Shall we merge :) ?

@ofek

ofek commented Jan 21, 2024

Copy link
Copy Markdown
Contributor

Yes this was on my schedule today, sorry for the wait! The workspaces feature I'm planning will definitely have to satisfy your use case in order to be merged and I will work closely with you when I have a PoC.

@ofek
ofek merged commit d167faa into pypa:master Jan 21, 2024
github-actions Bot pushed a commit that referenced this pull request Jan 21, 2024
Co-authored-by: Ofek Lev <ofekmeister@gmail.com> d167faa
@potiuk

potiuk commented Jan 21, 2024

Copy link
Copy Markdown
Contributor Author

Yes this was on my schedule today, sorry for the wait! The workspaces feature I'm planning will definitely have to satisfy your use case in order to be merged and I will work closely with you when I have a PoC.

Looking forward to it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants