-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
advice for maintainers on dropping universal=1 wheels #726
Comments
Yes! It's a great idea! I keep having So I was about to file an issue about it when I found this one :) The docs change should point out that the maintainers should be mindful of what their wheel tags are compared to what's written in the It also seems like a good idea to improve the linting side of the problem in the ecosystem: pypa/twine#739. P.S. I tested that projects having such metadata mismatches are harmless (if they don't have a hard conflict in that metadata) and pip seems to do the right thing but it's still a good idea to keep it in sync. |
Yep, comparing wheel filenames created with and without the flag:
Their contents are identical, except for
|
Before this change, `[bdist_wheel]` section of `setup.cfg` had `universal = 1` set and causing our automation to publish wheels tagged with `py2.py3` which implies that this wheel contains Python 2 compatible code. It is now corrected to produce just `py3` tag instead. Thanks to Bernát Gábor for pointing out that it's misconfigured! Ref: pypa/packaging.python.org#726 Co-Authored-By: Bernát Gábor <[email protected]>
Here you go #858. |
There should be some advice on what to do about universal wheels when dropping support for python versions in this guide: https://packaging.python.org/guides/dropping-older-python-versions/
eg, should this:
be removed?
The text was updated successfully, but these errors were encountered: