Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "Dropping old Python" with universal=0 #858

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Update "Dropping old Python" with universal=0 #858

merged 2 commits into from
Mar 11, 2021

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Mar 9, 2021

Resolves #726

@webknjaz webknjaz added the type: enhancement A self-contained enhancement or new feature label Mar 9, 2021
@webknjaz webknjaz requested a review from pradyunsg March 9, 2021 16:56
@webknjaz webknjaz mentioned this pull request Mar 9, 2021
Closed
@webknjaz webknjaz enabled auto-merge March 9, 2021 18:15
@webknjaz
Copy link
Member Author

@gaborbernat any feedback? ☝️

@webknjaz
Copy link
Member Author

cc @graingert @hugovk

hugovk
hugovk approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor wording suggestions!

source/guides/dropping-older-python-versions.rst Outdated Show resolved Hide resolved
source/guides/dropping-older-python-versions.rst Outdated Show resolved Hide resolved
gaborbernat
gaborbernat approved these changes Mar 11, 2021
View reviewed changes
Copy link

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webknjaz webknjaz merged commit 8dfdf5c into pypa:main Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@hugovk hugovk hugovk approved these changes

@gaborbernat gaborbernat gaborbernat approved these changes

Assignees
No one assigned
Labels
type: enhancement A self-contained enhancement or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

advice for maintainers on dropping universal=1 wheels
4 participants
@webknjaz @gaborbernat @hugovk @pradyunsg