Skip to content

Fix test expectations for .gitignore comment created by Python 3.13+ venv - #2672

Closed
hroncok wants to merge 1 commit into
pypa:mainfrom
hroncok:venv3.13
Closed

Fix test expectations for .gitignore comment created by Python 3.13+ venv#2672
hroncok wants to merge 1 commit into
pypa:mainfrom
hroncok:venv3.13

Conversation

@hroncok

@hroncok hroncok commented Nov 29, 2023

Copy link
Copy Markdown
Contributor

Since Python 3.13, the .gitignore file is created by venv:
python/cpython#108125

Fixes #2670

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

…venv

Since Python 3.13, the .gitignore file is created by venv:
python/cpython#108125

Fixes pypa#2670
@hroncok

hroncok commented Nov 29, 2023

Copy link
Copy Markdown
Contributor Author

I converted the PR to a draft to see if I could get Python 3.13 on the CI.

@hroncok
hroncok force-pushed the venv3.13 branch 2 times, most recently from 45ff4a8 to e3bd8e8 Compare November 29, 2023 16:31
@gaborbernat

Copy link
Copy Markdown
Contributor

I belive the CI will run with the main config because you don't have write access. However, you can enable GH actions for your fork at https://github.com/hroncok/virtualenv and we can use that.

@hroncok

hroncok commented Nov 29, 2023

Copy link
Copy Markdown
Contributor Author

I converted the PR to a draft to see if I could get Python 3.13 on the CI.

Let's not. I'll open a separate one to see all the errors without fixes: #2673

@hroncok
hroncok marked this pull request as ready for review November 29, 2023 16:32
@gaborbernat

Copy link
Copy Markdown
Contributor

I belive the CI will run with the main config because you don't have write access. However, you can enable GH actions for your fork at hroncok/virtualenv and we can use that.

Until you do this I cannot validate that your changes are valid because it doesn't run your PRs CI.

@hroncok

hroncok commented Nov 29, 2023

Copy link
Copy Markdown
Contributor Author

I can rebase this on #2673 to demonstrate the fix, but the CI will still fail due to the other issue.

@hroncok

hroncok commented Nov 29, 2023

Copy link
Copy Markdown
Contributor Author

To avoid a chicken and egg problem, I decided to add everything at #2673

@hroncok hroncok closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests/unit/create/test_creator.py::test_create_no_seed --creator venv fails on Python 3.13

2 participants