Skip to content

Conversation

@nlhkabu
Copy link
Contributor

@nlhkabu nlhkabu commented Dec 13, 2025

The new "Please confirm this login" page threw me for a while - as I could not find the email 😬

Updating the docs accordingly. I have also removed duplicated recovery codes.

Please review for accuracy.

@nlhkabu nlhkabu requested a review from a team as a code owner December 13, 2025 09:47
@nlhkabu nlhkabu force-pushed the add-email-instructions-to-docs branch from 3daa04e to 9fca2bc Compare December 13, 2025 09:49
@miketheman miketheman added documentation developer experience Anything that improves the experience for Warehouse devs labels Dec 16, 2025
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One optimization, update and good to go!

@di
Copy link
Member

di commented Dec 17, 2025

The docs updates LGTM, but this makes me wonder if we should also add a confirmed login for these users for 127.0.0.1 in the dev DB? @nlhkabu if you go to the admin UI for the user you confirmed the login for, is that the IP address shown?

@miketheman
Copy link
Member

I'll go ahead and merge this for now. @nlhkabu please feel free to respond to the query above!

@miketheman miketheman merged commit d1b22f0 into pypi:main Dec 17, 2025
21 checks passed
@nlhkabu
Copy link
Contributor Author

nlhkabu commented Dec 17, 2025

@di the IP address is showing as 172.18.0.1

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer experience Anything that improves the experience for Warehouse devs documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants