Skip to content

Conversation

ljwolf
Copy link
Member

@ljwolf ljwolf commented Nov 18, 2024

This adds the initial routing engine explained in #464.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

❌ Patch coverage is 0% with 354 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.2%. Comparing base (13ca45e) to head (8b11450).
⚠️ Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
spopt/route/utils.py 0.0% 149 Missing ⚠️
spopt/route/heuristic.py 0.0% 147 Missing ⚠️
spopt/route/engine.py 0.0% 58 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #465     +/-   ##
=======================================
- Coverage   77.8%   70.2%   -7.6%     
=======================================
  Files         27      32      +5     
  Lines       2638    4054   +1416     
=======================================
+ Hits        2053    2846    +793     
- Misses       585    1208    +623     
Files with missing lines Coverage Δ
spopt/route/engine.py 0.0% <0.0%> (ø)
spopt/route/heuristic.py 0.0% <0.0%> (ø)
spopt/route/utils.py 0.0% <0.0%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jGaboardi jGaboardi marked this pull request as ready for review September 26, 2025 15:17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple thoughts from the notebook before getting into code itself

  • notebook refers to spopt.Route
    • Is that meant to be referring to route.heuristic.LastMile?
    • Should we keep LastMile or consider renaming to Route?
    • Or other ideas?
  • need to remove hardcoded pathing -- dylan/projects/gsoc2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants