-
Couldn't load subscription status.
- Fork 1
Clean structure #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
srmnitc
wants to merge
90
commits into
main
Choose a base branch
from
clean_structure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Clean structure #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules
TODO
to_graphmethod called onActivitydoes not create structures againActivitymethod on transformationThis pull request introduces several enhancements and refactors across the
atomrdflibrary, focusing on modularizing the codebase, improving functionality for crystal structure generation, and standardizing I/O operations. Key changes include the addition of new utility functions, restructuring of I/O operations, and the introduction of new plotting and transformation capabilities.New Features and Enhancements:
Crystal Structure Generation:
bulkandlatticefunctions inatomrdf/build/bulk.pyto create and manage crystal structures with customizable parameters such as lattice constants, element types, and noise. These functions integrate withpyscal3andatomrdfsystems for seamless structure creation.I/O Operations:
writefunction inatomrdf/io/write.pyto handle file exports in various formats, including LAMMPS, POSCAR, and Quantum Espresso. This replaces the older_write_espressoimplementation, offering better modularity and support for additional formats.readfunction inatomrdf/io/read.pyto facilitate importing structures from multiple file formats, with options for specifying lattice properties and repetitions.Plotting Capabilities:
plotandplot3dfunctions inatomrdf/io/plot.pyfor visualizing atomic structures. These functions support multiple styles, such as property-based coloring and boolean property visualization, leveragingpyscal3andpyiron_atomistics.Code Refactoring:
Modularization:
atomrdf/io/plot.py,atomrdf/io/write.py,atomrdf/io/read.py). [1] [2]atomrdf/graph.pyby replacing direct calls toto_filewith the newwritefunction.Removal of Deprecated Code:
_convert_tab_to_dictandwrite_espressoimplementations fromatomrdf/io.py, consolidating their functionality into the newwritemodule.Minor Updates:
_declassinatomrdf/build/buildutils.pyto standardize handling of special variables likePropertyobjects.atomrdf/transform/__init__.pyto re-export all transformations for easier access.