-
Notifications
You must be signed in to change notification settings - Fork 37
add pyth patterns info in the pyth-connector example #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add pyth patterns info in the pyth-connector example #828
Conversation
Signed-off-by: master_jedy <[email protected]>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@masterjedy is attempting to deploy a commit to the Pyth Network Team on Vercel. A member of the Team first needs to authorize it. |
Signed-off-by: master_jedy <[email protected]>
@@ -124,6 +124,28 @@ This code snippet does the following: | |||
4. Prepares the update data and calculates the update fee. | |||
5. Updates the price feeds on the TON contract. | |||
|
|||
When providing Pyth data to your contract, there are typically two main scenarios: either you call a method supplying TON, or you transfer jettons. | |||
|
|||
They both are demonstrated in the [Pyth Connector example](https://github.com/pyth-network/pyth-examples/tree/main/price_feeds/ton/pyth-connector). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's not merged yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since the example is not merged yet I can't add links to the code, so I only described the same patterns using EVAA code samples and diagrams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel we should add links to Pyth-connector as well, that would be useful.
@@ -124,6 +124,28 @@ This code snippet does the following: | |||
4. Prepares the update data and calculates the update fee. | |||
5. Updates the price feeds on the TON contract. | |||
|
|||
When providing Pyth data to your contract, there are typically two main scenarios: either you call a method supplying TON, or you transfer jettons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we refer to the exact connector code block that shows these two scenarios ? That would help folks in better understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
connector is not merged yet, I used EVAA code for describing, pls take a look if it's ok.
Signed-off-by: master_jedy <[email protected]>
Signed-off-by: master_jedy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit is failing, please fix it.
Thanks @masterjedy for these diagrams. they look great! |
Signed-off-by: master_jedy <[email protected]>
Signed-off-by: master_jedy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's reference Pyth-connector for the two patterns.
Description
Provides short description of pyth data flow patterns used in pyth connector example and EVAA code.
Type of Change
documentation
Areas Affected
price_feeds / use-real-time-data / ton.mdx
Checklist
pre-commit run --all-files
to check for linting errorsRelated Issues
Closes #
Additional Notes
Contributor Information
Evaa protocol employee
Screenshots