-
Notifications
You must be signed in to change notification settings - Fork 38
docs: document that price field may be absent in Lazer payload reference #905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ali-behjati
merged 4 commits into
main
from
devin/1760519118-add-null-price-documentation
Oct 15, 2025
Merged
docs: document that price field may be absent in Lazer payload reference #905
ali-behjati
merged 4 commits into
main
from
devin/1760519118-add-null-price-documentation
Oct 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Added example JSON showing price field with null value - Added info callout explaining null price behavior - Added warning callout in Aggregate Market Price section - Documented that null indicates price could not be computed - Advised users to use last valid price or wait for fresh update Co-Authored-By: Nidhi Singh <[email protected]>
Co-Authored-By: Nidhi Singh <[email protected]>
a860550 to
85c8a88
Compare
nidhi-singh02
approved these changes
Oct 15, 2025
- Changed JSON example to show fields as absent rather than null - Updated callouts to reflect that fields are missing/absent - Clarified that price fields may be omitted from response when not computable Co-Authored-By: Nidhi Singh <[email protected]>
…d only - Removed third price feed example from JSON - Removed info callout that explained the example - Simplified warning callout to only mention price field - Removed mention of related optional fields (bestBidPrice, bestAskPrice, confidence) Co-Authored-By: Nidhi Singh <[email protected]>
ali-behjati
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added documentation to the Lazer payload reference explaining that the
pricefield may be absent from responses when the price cannot be computed. This provides users with guidance on how to handle this scenario.Type of Change
Areas Affected
/lazer/payload-reference.mdx- Added warning callout to the "Aggregate Market Price -price" sectionChecklist
pre-commit run --all-filesto check for linting errorsRelated Issues
N/A
Additional Notes
Important for reviewers:
User guidance provided:
When the price field is missing from a response, users should either use the last valid price they received or wait for a fresh update with a valid price.
Contributor Information