-
Notifications
You must be signed in to change notification settings - Fork 38
Add 'Why Update Prices' section to EVM Pull Integration guide #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Why Update Prices' section to EVM Pull Integration guide #908
Conversation
- Added a warning callout before the 'Write Contract Code' section - Explains the pull-based oracle model concept - Highlights advantages: lower costs, lower latency, flexibility - Details the three steps required in Pull integration - Warns about StalePrice error when prices aren't updated Co-Authored-By: Nidhi Singh <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Nidhi Singh <[email protected]>
|
|
||
| ## Why Update Prices? | ||
|
|
||
| <Callout type="warning" emoji="⚠️"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either you can place the title inside the callout or you remove the callout and put the text as a paragraph.
Co-Authored-By: Nidhi Singh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! I've moved the title inside the callout to address the redundancy. The callout now starts with "Why Update Prices?" as the first line.
|
add a section with title |
Per feedback from @nidhi-singh02: - Added 'Why Update Prices' as a section heading - Moved explanatory content outside the callout - Kept only the Important note about StalePrice errors in the callout Co-Authored-By: Nidhi Singh <[email protected]>
Description
Added a "Why Update Prices" section to the EVM Pull Integration guide that explains why price updates are required in Pyth's pull-based oracle model. This addresses a common point of confusion for developers new to Pyth who may be accustomed to traditional push oracles.
The section includes:
Type of Change
Areas Affected
pages/price-feeds/use-real-time-data/pull-integration/evm.mdx- Added new "Why Update Prices" section with explanatory content and warning calloutChecklist
npm run lintto check for linting errors (passed with no errors)Related Issues
N/A
Additional Notes
Structure:
This structure ensures the information flows naturally while emphasizing the critical warning about price staleness.
Contributor Information