Skip to content

Fix: drop delete buffer auction secs #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anihamde merged 2 commits into from
Aug 1, 2025
Merged

Fix: drop delete buffer auction secs #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fefedf
drop the delete buffer auction secs param
anihamde Aug 1, 2025
c733563
bump version
anihamde Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion auction-server/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "auction-server"
version = "0.35.2"
version = "0.36.0"
edition = "2021"
license-file = "license.txt"

Expand Down
6 changes: 0 additions & 6 deletions auction-server/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,6 @@ pub struct DeletePgRowsOptions {
#[arg(env = "DELETE_THRESHOLD_SECONDS")]
#[arg(default_value = "172800")] // 2 days in seconds
pub delete_threshold_secs: u64,

/// The buffer time to account for bids that may still exist in the db. We cannot delete auctions with ids that are still referenced by bids, so we wait an additional buffer time before deleting auctions.
#[arg(long = "delete-buffer-auction-seconds")]
#[arg(env = "DELETE_BUFFER_AUCTION_SECONDS")]
#[arg(default_value = "3600")] // 1 hour in seconds
pub delete_buffer_auction_secs: u64,
}

#[derive(Args, Clone, Debug)]
Expand Down
2 changes: 1 addition & 1 deletion auction-server/src/kernel/workers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ pub async fn run_delete_pg_db_history(

delete_pg_db_auction_history(
db,
delete_threshold_secs + delete_pg_rows_options.delete_buffer_auction_secs,
delete_threshold_secs,
)
.await?;
}
Expand Down
1 change: 0 additions & 1 deletion integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ def main():
f.write(f'export DELETE_ENABLED=true\n')
f.write(f'export DELETE_INTERVAL_SECONDS={1}\n')
f.write(f'export DELETE_THRESHOLD_SECONDS={60*60*24*2}\n')
f.write(f'export DELETE_BUFFER_AUCTION_SECONDS={60*60}\n')

mint_buy = Keypair.from_json((open('keypairs/mint_buy.json').read())).pubkey()
mint_sell = Keypair.from_json((open('keypairs/mint_sell.json').read())).pubkey()
Expand Down
Loading