Add pyproject.toml and versioning #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Falcon provides a WSGI app which can be used by any server, not just gunicorn. Thus, make gunicorn optional in case the user wants to use a different server. There shouldn't be any import errors since the class is now in an isolated module. The only time that module is imported is when gunicorn loads its config. Sentry is there for Python Discord mainly, so this dependency shouldn't be imposed on others.
Use the HEAD commit's date as the package's version. Append the number of commits made on the same date as HEAD to ensure multiple releases on the same date still have unique versions.
Subpackages weren't being included.
MarkKoz
added
type: feature
Akarys42
approved these changes
Jun 1, 2022
| @@ -2,8 +2,13 @@ | |||
| * | |||
|
|
|||
| # Make exceptions for what's needed | |||
| !snekbox | |||
| !.git/ | |||
There was a problem hiding this comment.
This could be further filtered to speed up transfer time, but I doubt it is worth spending time on.
There was a problem hiding this comment.
I'm not familiar with the structure of the directory and what exactly I need. However, it's never even copied; it's just mounted.
Co-authored-by: Matteo Bertucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pyproject.tomlusing setuptools as the PEP 517 build backendpyproject.tomlThe addition of versioning is progress towards #138. Originally I planned to just use the commit SHA, but I realised that it's not an adequate version since it cannot be properly constrained (except for
==). I chose CalVer because I don't want the maintenance burden of SemVer and I don't want to have to tag releases. Deriving the version from the commit allows for the current workflow to remain: every push to master creates a new release that is deployed automatically.Review Process
Try installing the package (
pip install .), importing it, and checking that the__version__matches the HEAD commit's date. Also run the tests withmake testto ensure the dev container still works.