Fix minor typo in workspace.py #649
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
reviewed
May 28, 2025
| def get_enviroment(self, environment_path=None, env_vars=None): | ||
| def get_environment(self, environment_path=None, env_vars=None): |
There was a problem hiding this comment.
I am nor sure if anyone uses it, but shall we preserve get_enviroment (with typo, but mention it is deprecated in docstring) and make it call get_environment (and return its result) to make sure we are not breaking plugins if any does use it?
Or do we assume this was not meant to be a public API? In that case, should it be renamed to start with underscore?
There was a problem hiding this comment.
I agree with @krassowski on this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enviroment -> environment