Skip to content

Rename 16-bit RGB rawmodes #8158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Rename 16-bit RGB rawmodes #8158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7d5771e
parametrize test_lib_pack.py
Yay295 Apr 27, 2024
3af0e2d
add "new" rawmodes for 16-bit RGB data
Yay295 Apr 26, 2024
5ffaf3f
clean up rawmode syntax comments
Yay295 May 1, 2024
f281063
use new rawmodes in BMP and TGA image plugins
Yay295 May 1, 2024
adcd541
deprecate old rawmodes for 16-bit RGB data
Yay295 May 8, 2024
d330a13
move deprecated rawmode unpack tests to test_unpack_deprecated()
Yay295 Jun 22, 2024
976f307
don't show rawmode deprecation warning if mode is same as rawmode
Yay295 Jun 22, 2024
75e54c2
add check for deprecated rawmodes when creating an ImagePalette
Yay295 Jun 26, 2024
89bafd3
remove unpackers with identical output
radarhere Jun 29, 2024
01f4c54
Merge branch 'main' into 16bit_rgb_rawmodes
radarhere Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tests/test_file_tga.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def test_rgba_16() -> None:
with Image.open("Tests/images/rgba16.tga") as im:
assert im.mode == "RGBA"

assert im.getpixel((0, 0)) == (172, 0, 255, 255)
assert im.getpixel((0, 0)) == (173, 0, 255, 255)
assert im.getpixel((1, 0)) == (0, 255, 82, 0)


Expand Down
6 changes: 6 additions & 0 deletions Tests/test_imagepalette.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,12 @@ def test_rawmode_valueerrors(tmp_path: Path) -> None:
palette.save(f)


@pytest.mark.parametrize("rawmode", Image._DEPRECATED_RAWMODES)
def test_rawmode_deprecated(rawmode: str) -> None:
with pytest.warns(DeprecationWarning):
ImagePalette.raw(rawmode, b"")


def test_getdata() -> None:
# Arrange
data_in = list(range(256)) * 3
Expand Down
Loading
Loading