Skip to content

Select keyboard #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

david-shiko
Copy link
Contributor

This module implement checkbox buttons for PTB inline keyboard

@Bibo-Joshi
Copy link
Member

What's the difference between #119 and #123? If they have the same content, then please update #119 instead of creating a new PR ;)

@david-shiko
Copy link
Contributor Author

HI! No, they are different, I added new entire module select_keyboard.py.
P.S. the old PR still should be fixed, I will do it later.

@Bibo-Joshi
Copy link
Member

Okay so it's an extension of #119? Since #119 is not merged yet, I recommend to still just include it there. If you don't want that for some reason, please mark #123 as WIP so that reviewing is postponed until after #119 is merged

@Bibo-Joshi
Copy link
Member

please let me know how you want to go on with #123 & #119 and when you want me to review which one of those.

@david-shiko
Copy link
Contributor Author

please let me know how you want to go on with #123 & #119 and when you want me to review which one of those.

This pull request includes improvements to both #123 and #119 issues.

Therefore, it can be considered the final revision.

@Bibo-Joshi
Copy link
Member

@david-shiko are you still interested in working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants