Skip to content

Commit

Permalink
Merge pull request #3211 from musicinmybrain/issue-3209
Browse files Browse the repository at this point in the history
Add xfail for issue 3209, and start testing Python 3.14
  • Loading branch information
A5rocks authored Feb 14, 2025
2 parents 5eb5afb + 6b63492 commit d63f3a9
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python: ['3.9', '3.10', '3.11', '3.12', '3.13']
python: ['3.9', '3.10', '3.11', '3.12', '3.13', '3.14']
arch: ['x86', 'x64']
lsp: ['']
lsp_extract_file: ['']
Expand Down Expand Up @@ -237,7 +237,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python: ['pypy-3.10', '3.9', '3.10', '3.11', '3.12', '3.13']
python: ['pypy-3.10', '3.9', '3.10', '3.11', '3.12', '3.13', '3.14']
check_formatting: ['0']
no_test_requirements: ['0']
extra_name: ['']
Expand Down Expand Up @@ -301,7 +301,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python: ['pypy-3.10', '3.9', '3.10', '3.11', '3.12', '3.13']
python: ['pypy-3.10', '3.9', '3.10', '3.11', '3.12', '3.13', '3.14']
continue-on-error: >-
${{
(
Expand Down
4 changes: 4 additions & 0 deletions src/trio/_core/_tests/test_run.py
Original file line number Diff line number Diff line change
Expand Up @@ -2817,6 +2817,10 @@ def no_other_refs() -> list[object]:
sys.implementation.name != "cpython",
reason="Only makes sense with refcounting GC",
)
@pytest.mark.xfail(
sys.version_info >= (3, 14),
reason="https://github.com/python/cpython/issues/125603",
)
async def test_ki_protection_doesnt_leave_cyclic_garbage() -> None:
class MyException(Exception):
pass
Expand Down
2 changes: 1 addition & 1 deletion test-requirements.in
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ cryptography>=41.0.0 # cryptography<41 segfaults on pypy3.10
# Tools
black; implementation_name == "cpython"
mypy # Would use mypy[faster-cache], but orjson has build issues on pypy
orjson; implementation_name == "cpython"
orjson; implementation_name == "cpython" and python_version < "3.14" # orjson does not yet install on 3.14
ruff >= 0.8.0
astor # code generation
uv >= 0.2.24
Expand Down
2 changes: 1 addition & 1 deletion test-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ nodeenv==1.9.1
# via
# pre-commit
# pyright
orjson==3.10.15 ; implementation_name == 'cpython'
orjson==3.10.15 ; python_full_version < '3.14' and implementation_name == 'cpython'
# via -r test-requirements.in
outcome==1.3.0.post0
# via -r test-requirements.in
Expand Down

0 comments on commit d63f3a9

Please sign in to comment.