Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyright output #2769

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Fix pyright output #2769

merged 4 commits into from
Aug 22, 2023

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Aug 21, 2023

cc @jakkdl hopefully this still accomplishes the goals you wanted when you originally made all the diagnostics happen.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #2769 (85c61eb) into master (20f5435) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2769   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files         113      113           
  Lines       16843    16843           
  Branches     3036     3036           
=======================================
  Hits        16665    16665           
  Misses        123      123           
  Partials       55       55           

@jakkdl
Copy link
Member

jakkdl commented Aug 21, 2023

yeah this is great, thanks for the quick fix!

@A5rocks A5rocks merged commit ef6d8ee into python-trio:master Aug 22, 2023
@A5rocks A5rocks deleted the fix-pyright-output branch August 22, 2023 00:39
@jakkdl
Copy link
Member

jakkdl commented Aug 23, 2023

I think I must've broken check.sh, as otherwise it should've given an error when the path differed in CI

@jakkdl
Copy link
Member

jakkdl commented Aug 23, 2023

oh nvm, it turned up in #2768. Not sure why it didn't get triggered in #2767 though

@A5rocks A5rocks mentioned this pull request Aug 25, 2023
@A5rocks A5rocks added the typing Adding static types to trio's interface label Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typing Adding static types to trio's interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants