-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the regular readme for the long description #2866
use the regular readme for the long description #2866
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2866 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 117 117
Lines 17634 17634
Branches 3172 3172
=======================================
Hits 17572 17572
Misses 43 43
Partials 19 19 |
Personally I like having a customized version of README for pypi even if it has caused issues due be being out of sync in the past. (people seeing trio in pypi have different goals than people seeing trio on github. but idk if we adequately address that as is...) |
Genuinely, do people ever actually read the pypi readmes? I nearly always just click through to the repository instead (usually because the readme is outdated and wrong). |
-snip- huh I can't find an archived page to support my memory so I was probably just misremembering. But I do think I agree that they aren't looked at much... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I've come around on this, I agree with @Fuyukai that nobody really looks at these and that any upkeep burden is too much.
file = "README.rst" | ||
content-type = "text/x-rst" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to specify content-type
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's best practice, but I am not certain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense
No description provided.