-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move -p trio._tests.pytest_plugin
to project addopts and add --pyargs trio
#2870
Conversation
…rgs trio` Fixes #2863 Signed-off-by: Tomasz Kłoczko <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2870 +/- ##
=======================================
Coverage 99.51% 99.51%
=======================================
Files 115 115
Lines 17683 17683
Branches 3172 3172
=======================================
Hits 17598 17598
Misses 56 56
Partials 29 29 |
Thank you! It looks like
Did you mean to replace |
That is odd .. it should go to pytest arguments. One sec will double check that sending that to my own build automation 😋 |
This alternative invocation method imports stuff differently and may have other side effects. I don't think the project should be using it. |
Sorry to not reacting bu I was busy 😞 |
Hey @kloczek, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂 If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:
If you want to read more, here's the relevant section in our contributing guide. Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you. If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out! |
Thx 👍 |
Fixes #2863