Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move -p trio._tests.pytest_plugin to project addopts and add --pyargs trio #2870

Merged
merged 6 commits into from
Nov 18, 2023
Merged

Conversation

kloczek
Copy link
Contributor

@kloczek kloczek commented Nov 5, 2023

Fixes #2863

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #2870 (9ff3403) into master (d5c0fb8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2870   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         115      115           
  Lines       17683    17683           
  Branches     3172     3172           
=======================================
  Hits        17598    17598           
  Misses         56       56           
  Partials       29       29           

@A5rocks
Copy link
Contributor

A5rocks commented Nov 5, 2023

Thank you! It looks like --pyargs trio isn't necessary or is messing something up:

ERROR: file or directory not found: --pyargs trio


Did you mean to replace ${INSTALLDIR} with --pyargs trio?

@kloczek
Copy link
Contributor Author

kloczek commented Nov 5, 2023

Did you mean to replace ${INSTALLDIR} with --pyargs trio?

That is odd .. it should go to pytest arguments.
BTW addopts can be just string without quotes (I'm not sure why it is used table)

One sec will double check that sending that to my own build automation 😋

@webknjaz
Copy link
Member

Thank you! It looks like --pyargs trio isn't necessary or is messing something up:

This alternative invocation method imports stuff differently and may have other side effects. I don't think the project should be using it.

@kloczek
Copy link
Contributor Author

kloczek commented Nov 17, 2023

Sorry to not reacting bu I was busy 😞

@A5rocks A5rocks merged commit 20d6c87 into python-trio:master Nov 18, 2023
27 checks passed
@trio-bot
Copy link

trio-bot bot commented Nov 18, 2023

Hey @kloczek, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

@kloczek
Copy link
Contributor Author

kloczek commented Nov 19, 2023

Thx 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.23.1: problems with testing trio
5 participants