Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install uv with uv #3131

Closed
wants to merge 11 commits into from
Closed

install uv with uv #3131

wants to merge 11 commits into from

Conversation

graingert
Copy link
Member

also avoid pip entirely in ci

this works around the issue where pip could not install uv on pypy on windows with a broken cache

@graingert graingert marked this pull request as draft November 7, 2024 20:50
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63156%. Comparing base (0ee5a69) to head (35965ad).
Report is 257 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main       #3131         +/-   ##
===================================================
+ Coverage   99.63003%   99.63156%   +0.00152%     
===================================================
  Files            122         126          +4     
  Lines          18380       18456         +76     
  Branches        1222        1226          +4     
===================================================
+ Hits           18312       18388         +76     
  Misses            47          47                 
  Partials          21          21                 
Files with missing lines Coverage Δ
src/trio/_tests/tools/test_find_activate_script.py 100.00000% <100.00000%> (ø)
src/trio/_tests/tools/test_find_uv_script_url.py 100.00000% <100.00000%> (ø)
src/trio/_tools/find_activate_script.py 100.00000% <100.00000%> (ø)
src/trio/_tools/find_uv_script_url.py 100.00000% <100.00000%> (ø)

@CoolCat467
Copy link
Member

CoolCat467 commented Nov 8, 2024

Also, for resolving windows virtual environment issues, I also had that problem while working on #2957, and something like this should help:
https://github.com/CoolCat467/trio/blob/a359dacc2bbaaf24586771d783e3c19b99c30dab/ci.sh#L51
Looking at that, the changes with PYTHON_PATH are not necessary here, not handling pre-installed virtual environment case.

@graingert
Copy link
Member Author

Also, for resolving windows virtual environment issues, I also had that problem while working on #2957, and something like this should help: https://github.com/CoolCat467/trio/blob/a359dacc2bbaaf24586771d783e3c19b99c30dab/ci.sh#L51 Looking at that, the changes with PYTHON_PATH are not necessary here, not handling pre-installed virtual environment case.

I plan to pull the Script Vs bin out of sysconfig.get_path

@graingert graingert marked this pull request as ready for review November 8, 2024 11:12
@graingert graingert requested a review from CoolCat467 November 8, 2024 11:12
@A5rocks
Copy link
Contributor

A5rocks commented Nov 9, 2024

Sorry, I'm still not sold on this as a solution. I think it would be significantly better to just avoid setup-python's cache on PyPy+Windows runs.

@graingert graingert closed this Nov 9, 2024
@graingert graingert deleted the install-uv-with-uv branch November 9, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants