Bump Codecov action to v5 #3161
Conversation
webknjaz
force-pushed
the
maintenance/codecov-v5
branch
3 times, most recently
from
a4c4838 to
e2b6bb6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3161 +/- ##
=====================================================
- Coverage 100.00000% 55.50685% -44.49315%
=====================================================
Files 124 246 +122
Lines 18460 37644 +19184
Branches 1216 2727 +1511
=====================================================
+ Hits 18460 20895 +2435
- Misses 0 16426 +16426
- Partials 0 323 +323 |
|
#2951 should have some prior research |
|
Yeah, that also surprised me. It does need research… One should probably start by comparing the payloads between the PR and main.. |
|
@webknjaz I think you've not enabled edits from maintainers, so I can't update this branch from the base branch for you |
|
Yeah, I often disable that. |
webknjaz
force-pushed
the
maintenance/codecov-v5
branch
from
e2b6bb6 to
1290249
Compare
|
Anyway, with the huge reported coverage drop and the flakiness I was observing in Ansible, I'd like to investigate what's broken in Codecov first. |
| # `nodejs` for pyright (`node-env` pulls in nodejs but that takes a while and can time out the test). | ||
| # `perl` for a platform independent `sed -i` alternative | ||
| run: apk update && apk add python3-dev bash nodejs perl | ||
| run: apk update && apk add python3-dev bash curl gpg git jq nodejs perl |
There was a problem hiding this comment.
fyi, jq should no longer be needed. I'm working on gpg and git, though git is probably still recommended
There was a problem hiding this comment.
That's too bad. The best practice is to build and test from sdist, meaning that there would be no Git repo on disk.
It's more stable and requires a token that is already in the config. Alpine needs curl, gpg, git and jq because of a bug in codecov-action [[1]]. [1]: codecov/codecov-action#1320
webknjaz
force-pushed
the
maintenance/codecov-v5
branch
from
1290249 to
b2862a4
Compare
It's more stable and requires a token that is already in the config.