Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type hint for the CancelStatus.parent setter #3191

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Jan 23, 2025

Type hint issue spotted in python/mypy#18510

Maybe we should wait for that to be merged (and maybe released?) to check this works.

@A5rocks A5rocks added the skip newsfragment Newsfragment is not required label Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00000%. Comparing base (ed2a7d3) to head (d11481b).
Report is 48 commits behind head on main.

Additional details and impacted files
@@               Coverage Diff               @@
##                 main        #3191   +/-   ##
===============================================
  Coverage   100.00000%   100.00000%           
===============================================
  Files             124          124           
  Lines           18460        18460           
  Branches         1216         1216           
===============================================
  Hits            18460        18460           
Files with missing lines Coverage Δ
src/trio/_core/_run.py 100.00000% <100.00000%> (ø)

@TeamSpen210
Copy link
Contributor

Before that PR setter hints were effectively ignored (aside from property implementation), so it should be fine. Could just install the PR code locally to check.

Copy link
Member

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough, don't see any reason why this wouldn't be mergeable at this time even though the mypy PR hasn't gone through yet.

@A5rocks A5rocks added typing Adding static types to trio's interface and removed typing Adding static types to trio's interface labels Jan 23, 2025
@jakkdl jakkdl added this pull request to the merge queue Jan 29, 2025
Merged via the queue into python-trio:main with commit d7cb2fc Jan 29, 2025
42 checks passed
@A5rocks A5rocks deleted the fix-parent-setter-type branch January 30, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip newsfragment Newsfragment is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants