-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing arguments to run_process #3212
base: main
Are you sure you want to change the base?
Conversation
f050eba
to
b81444d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3212 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 124 124
Lines 18764 18771 +7
Branches 1269 1269
===============================================
+ Hits 18764 18771 +7
|
d3e7789
to
e377c32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked terribly close at the arguments, but seems fine at a glance.
In an ideal world it'd maybe be nice to have tests.. but it sounds messy to write something that validates against typeshed signatures and handles version/platform differences.
Fixes #3183
I tried out TypedDict here like @decorator-factory recommended and it's nicer, though it's explicitly trading off user experience:
I think it's worth it? I doubt people are looking at overloads for the defaults to things.
I still need to add type tests.