Fix parsing color as sequence of byte ints #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conengmo
force-pushed
the
fix-parse-color-sequence-of-ints
branch
from
4c00bad to
10c0dcc
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Conengmo
changed the title
Conengmo
force-pushed
the
fix-parse-color-sequence-of-ints
branch
from
c9d9ad9 to
2de024f
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #190.
Fix the issue: color components that are byte values between 0 and 255 should be converted to normalized floats between 0 and 1.
I noticed our code here is quite sparse. When addressing this code, I strive to add more checks and more meaningful error messages. Downside is that it makes the code more verbose, but I hope the explicitness is helpful.
I also added tests for the other parsing related functions.