Skip to content

Conversation

freakboy3742
Copy link
Contributor

An update to #624 - it looks like the issue was the working directory not including the OOT build prefix.

@encukou
Copy link
Member

encukou commented Aug 29, 2025

Got SSH to prod so I used it.

Build https://buildbot.python.org/#/builders/1810/builds/412 used the config. from this PR.
The build/Tools shows up in PWD, but Buildbot is still trying to use /bin/run_test.sh. (Looks like some over-eager normalization throws away the ./ too early.)

Now trying with:

--- a/master/custom/factories.py
+++ b/master/custom/factories.py
@@ -1396,7 +1396,7 @@ class EmscriptenBuild(BaseBuild):
             Test(
                 name="PyRepl in Chrome smoke test",
                 command=[
-                    "./run_test.sh",
+                    "build/Tools/wasm/emscripten/browser_test/run_test.sh",
                 ],
                 env=compile_environ,
                 timeout=step_timeout(self.test_timeout),

@encukou
Copy link
Member

encukou commented Aug 29, 2025

This one should work.

@encukou encukou merged commit 3119da4 into python:main Aug 29, 2025
1 check passed
@encukou
Copy link
Member

encukou commented Aug 29, 2025

I assume the Playwright error should be solved by installing deps on the worker:

    ╔══════════════════════════════════════════════════════╗
    ║ Host system is missing dependencies to run browsers. ║
    ║ Please install them with the following command:      ║
    ║                                                      ║
    ║     sudo npx playwright install-deps                 ║
    ║                                                      ║
    ║ Alternatively, use apt:                              ║
    ║     sudo apt-get install libatk1.0-0\                ║
    ║         libatk-bridge2.0-0\                          ║
    ║         libatspi2.0-0\                               ║
    ║         libxcomposite1\                              ║
    ║         libxdamage1\                                 ║
    ║         libgbm1\                                     ║
    ║         libxkbcommon0                                ║
    ║                                                      ║
    ║ <3 Playwright Team                                   ║
    ╚══════════════════════════════════════════════════════╝

@freakboy3742 freakboy3742 deleted the emscripten-path-fix branch August 31, 2025 22:46
@freakboy3742
Copy link
Contributor Author

@encukou I've installed the dependencies on the worker; and it looks like we've got a clean build! Thanks for the debugging work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants