test_exceptions are leaked

[Eclips4]

Tried on last commit

PS C:\Users\KIRILL-1\CLionProjects\cpython> ./python -m test -R 3:3 test_exceptions
Running Debug|x64 interpreter...
0:00:00 Run tests sequentially
0:00:00 [1/1] test_exceptions
beginning 6 repetitions
123456
......
test_exceptions leaked [18, 18, 18] references, sum=54
test_exceptions leaked [12, 12, 12] memory blocks, sum=36
test_exceptions failed (reference leak) in 38.1 sec

== Tests result: FAILURE ==

1 test failed:
    test_exceptions

Total duration: 38.2 sec
Tests result: FAILURE

OS: Windows 10

Linked PRs

• gh-104454: Fix refleak in AttributeError_reduce #104455

[iritkatriel]

More specifically:

% ./python.exe -m test -R3:3 test_exceptions -m testAttributes 
Raised RLIMIT_NOFILE: 256 -> 1024
0:00:00 load avg: 3.46 Run tests sequentially
0:00:00 load avg: 3.46 [1/1] test_exceptions
beginning 6 repetitions
123456
......
test_exceptions leaked [18, 18, 18] references, sum=54
test_exceptions leaked [12, 12, 12] memory blocks, sum=36
test_exceptions failed (reference leak)

== Tests result: FAILURE ==

1 test failed:
    test_exceptions

Total duration: 256 ms
Tests result: FAILURE

[csm10495]

PR opened to fix. Thanks folks. For my benefit: Why doesn't this test run on PRs?

[AlexWaygood]

PR opened to fix. Thanks folks. For my benefit: Why doesn't this test run on PRs?

Running the refleak tests generally takes a while, and isn't necessary for most PRs to CPython. We have a label we can add to PRs to trigger the test being run; in this case, looks like we just forgot to add that label to this PR. It's not a big issue; happens quite often around here :-)

[gpshead]

thanks for the fix. I missed this leak in review (easy for anyone to miss - our C API is full of sharp edges) and didn't think to trigger the refleaks buildbots on the original PR. it happens, no worries.