Regression in pkgutil: iter_modules stopped taking Path argument in python 3.8.10 and 3.9.5

[rikardnordgren]

BPO	44061
Nosy	@gpshead, @ambv, @zooba, @shreyanavigyan, @miguendes, @magul
PRs	bpo-44061: Fix pkgutil.iter_modules regression #25964 [3.9] bpo-44061: Fix pkgutil.iter_modules regression when passed a pathlib.Path object (GH-25964) #26052 [3.8] bpo-44061: Fix pkgutil.iter_modules regression when passed a pathlib.Path object (GH-25964) #26056

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/zooba'
closed_at = <Date 2021-05-11.23:34:04.647>
created_at = <Date 2021-05-06.17:54:01.802>
labels = ['easy', 'type-bug', '3.8', '3.9', '3.10', '3.11', 'release-blocker', 'library']
title = 'Regression in pkgutil: iter_modules stopped taking Path argument in python 3.8.10 and 3.9.5'
updated_at = <Date 2021-05-12.10:18:11.716>
user = 'https://bugs.python.org/rikardnordgren'

bugs.python.org fields:

activity = <Date 2021-05-12.10:18:11.716>
actor = 'lukasz.langa'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2021-05-11.23:34:04.647>
closer = 'steve.dower'
components = ['Library (Lib)']
creation = <Date 2021-05-06.17:54:01.802>
creator = 'rikard.nordgren'
dependencies = []
files = []
hgrepos = []
issue_num = 44061
keywords = ['patch', 'easy', '3.8regression', '3.9regression']
message_count = 12.0
messages = ['393120', '393128', '393130', '393132', '393133', '393135', '393147', '393154', '393168', '393478', '393494', '393498']
nosy_count = 7.0
nosy_names = ['gregory.p.smith', 'lukasz.langa', 'steve.dower', 'shreyanavigyan', 'miguendes', 'rikard.nordgren', 'magul']
pr_nums = ['25964', '26052', '26056']
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue44061'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10', 'Python 3.11']

[rikardnordgren]

The pkgutil.iter_modules crash when using Path object in the first argument. The code below works in python 3.8.9 and 3.9.4, but stopped working in python 3.8.10 and 3.9.5. Changing from Path to str works in all versions.

import pkgutil
from pathlib import Path

for _, modname, ispkg in pkgutil.iter_modules([Path("/home")], 'somepackage.somesubpackage'):
print(modname, ispkg)

Error message from python 3.8.10 (other path was used):

Traceback (most recent call last):
  File "/home/devel/Python-3.8.10/Lib/pkgutil.py", line 415, in get_importer
    importer = sys.path_importer_cache[path_item]
KeyError: PosixPath('/home/devel/pharmpy/src/pharmpy/plugins')

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "pyissue.py", line 5, in <module>
    for _, modname, ispkg in pkgutil.iter_modules([Path("/home/devel/pharmpy/src/pharmpy/plugins")], 'pharmpy.plugins'):
  File "/home/devel/Python-3.8.10/Lib/pkgutil.py", line 129, in iter_modules
    for i in importers:
  File "/home/devel/Python-3.8.10/Lib/pkgutil.py", line 419, in get_importer
    importer = path_hook(path_item)
  File "<frozen importlib._bootstrap_external>", line 1594, in path_hook_for_FileFinder
  File "<frozen importlib._bootstrap_external>", line 1469, in __init__
  File "<frozen importlib._bootstrap_external>", line 177, in _path_isabs
AttributeError: 'PosixPath' object has no attribute 'startswith'

[gpshead]

https://bugs.python.org/issue43105 and #25121 caused this regression.