TimedRotatingFileHandler deletes wrong files

[SamiSalonen]

BPO	46063
Nosy	@vsajip, @miss-islington, @iritkatriel
PRs	bpo-46063: Improve algorithm for computing which rolled-over log file… (GH-30093) #30093 [3.10] bpo-46063: Improve algorithm for computing which rolled-over log file… (GH-30093) (GH-30094) #30094 [3.9] bpo-46063: Improve algorithm for computing which rolled-over log file… (GH-30093) (GH-30095) #30095 bpo-46063: Add 'delay=True' to file handler initialization. (GH-30103) #30103 [3.10] bpo-46063: Add 'delay=True' to file handler initialization. (GH-30103) (GH-30104) #30104 [3.9] bpo-46063: Add 'delay=True' to file handler initialization. (GH-30103) (GH-30105) #30105

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-12-14.10:01:53.983>
created_at = <Date 2021-12-13.12:12:03.236>
labels = ['type-bug', 'library', '3.9', '3.10', '3.11']
title = 'TimedRotatingFileHandler deletes wrong files'
updated_at = <Date 2021-12-14.17:27:26.542>
user = 'https://bugs.python.org/SamiSalonen'

bugs.python.org fields:

activity = <Date 2021-12-14.17:27:26.542>
actor = 'vinay.sajip'
assignee = 'none'
closed = True
closed_date = <Date 2021-12-14.10:01:53.983>
closer = 'vinay.sajip'
components = ['Library (Lib)']
creation = <Date 2021-12-13.12:12:03.236>
creator = 'Sami Salonen'
dependencies = []
files = []
hgrepos = []
issue_num = 46063
keywords = ['patch']
message_count = 10.0
messages = ['408445', '408446', '408506', '408509', '408510', '408521', '408522', '408548', '408552', '408553']
nosy_count = 4.0
nosy_names = ['vinay.sajip', 'Sami Salonen', 'miss-islington', 'iritkatriel']
pr_nums = ['30093', '30094', '30095', '30103', '30104', '30105']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue46063'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

[SamiSalonen]

https://bugs.python.org/issue45628 breaks file rotation.

I name my log files after module name, run the modules in separate processes, use the same log config in them, and store the log files in one common directory. For example, for modules a.b and a.b.c I have the following log files:

a.b.log
a.b.c.log

Now after bpo-45628 fix, getFilesToDelete treats the rotated log files from those modules the same, and deletes wrong files. If backupCount is set to e.g. 7, only total of 7 files are stored instead of 7 of each.

[SamiSalonen]

Breaking PR: #29310

[vsajip]

New changeset cb589d1 by Vinay Sajip in branch 'main':
bpo-46063: Improve algorithm for computing which rolled-over log file… (GH-30093)
cb589d1

[vsajip]

New changeset f84e2f6 by Miss Islington (bot) in branch '3.10':
[3.10] bpo-46063: Improve algorithm for computing which rolled-over log file… (GH-30093) (GH-30094)
f84e2f6

[vsajip]

New changeset 9423422 by Miss Islington (bot) in branch '3.9':
[3.9] bpo-46063: Improve algorithm for computing which rolled-over log file… (GH-30093) (GH-30095)
9423422