Skip to content

gh-128734: Fix ResourceWarning in urllib tests - #128735

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:test_urllib-warnings
Jan 12, 2025
Merged

gh-128734: Fix ResourceWarning in urllib tests#128735
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:test_urllib-warnings

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jan 11, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 11, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 11, 2025
Closed
@serhiy-storchaka
serhiy-storchaka merged commit 5ace717 into python:main Jan 12, 2025
@miss-islington-app

miss-islington-app Bot commented Jan 12, 2025

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@serhiy-storchaka
serhiy-storchaka deleted the test_urllib-warnings branch January 12, 2025 10:53
@miss-islington-app

miss-islington-app Bot commented Jan 12, 2025

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5ace71713b03cb37d829f50c849a8bb8a518738d 3.13

@miss-islington-app

miss-islington-app Bot commented Jan 12, 2025

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5ace71713b03cb37d829f50c849a8bb8a518738d 3.12

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jan 12, 2025
@serhiy-storchaka
[3.13] pythongh-128734: Fix ResourceWarning in urllib tests (pythonGH…
0fe7ba5 
…-128735)

(cherry picked from commit 5ace717)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-app Bot commented Jan 12, 2025

Copy link
Copy Markdown

GH-128748 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jan 12, 2025
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jan 12, 2025
@serhiy-storchaka
[3.12] pythongh-128734: Fix ResourceWarning in urllib tests (pythonGH…
092e916 
…-128735)

(cherry picked from commit 5ace717)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-app Bot commented Jan 12, 2025

Copy link
Copy Markdown

GH-128748 is a backport of this pull request to the 3.13 branch.

@bedevere-app

bedevere-app Bot commented Jan 12, 2025

Copy link
Copy Markdown

GH-128750 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 12, 2025
serhiy-storchaka added a commit that referenced this pull request Jan 12, 2025
@serhiy-storchaka
[3.12] gh-128734: Explicitly close sockets in urllib tests (GH-128735) (
c20c551 
GH-128750)

(cherry picked from commit 5ace717)
serhiy-storchaka added a commit that referenced this pull request Jan 12, 2025
@serhiy-storchaka
[3.13] gh-128734: Explicitly close sockets in urllib tests (GH-128735) (
6116e1b 
GH-128748)

(cherry picked from commit 5ace717)
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@serhiy-storchaka