Skip to content

gh-142224: makeunicodedata.py: parse default bidi values - #144815

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
StanFromIreland:unicodetata-bidis
Feb 18, 2026
Merged

gh-142224: makeunicodedata.py: parse default bidi values#144815
serhiy-storchaka merged 5 commits into
python:mainfrom
StanFromIreland:unicodetata-bidis

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Feb 14, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Feb 14, 2026
Closed
serhiy-storchaka
serhiy-storchaka reviewed Feb 17, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to work on this issue next week, but you saved my time. Thank you.

Comment thread Tools/unicode/makeunicodedata.py Outdated
Comment thread Tools/unicode/makeunicodedata.py Outdated
Comment thread Tools/unicode/makeunicodedata.py Outdated
@StanFromIreland
Updates for Serhiy
b665e66
@StanFromIreland
Merge branch 'main' into unicodetata-bidis
0262063 
# Conflicts:
#	Lib/test/test_unicodedata.py
#	Tools/unicode/makeunicodedata.py
serhiy-storchaka
serhiy-storchaka reviewed Feb 18, 2026
View reviewed changes
Comment thread Tools/unicode/makeunicodedata.py Outdated
Comment thread Tools/unicode/makeunicodedata.py Outdated
@malemburg

malemburg commented Feb 18, 2026

Copy link
Copy Markdown
Member

Sorry, I don't have time for a true review. From a casual look, this LGTM, though.

serhiy-storchaka
serhiy-storchaka approved these changes Feb 18, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka
serhiy-storchaka merged commit e49bfca into python:main Feb 18, 2026
51 checks passed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Feb 18, 2026
@miss-islington-app

miss-islington-app Bot commented Feb 18, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Feb 18, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Feb 18, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e49bfca87cc188c271946491edc33831a901c7f1 3.13

@miss-islington-app

miss-islington-app Bot commented Feb 18, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland and @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e49bfca87cc188c271946491edc33831a901c7f1 3.14

@serhiy-storchaka serhiy-storchaka removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Feb 18, 2026
@serhiy-storchaka

serhiy-storchaka commented Feb 18, 2026

Copy link
Copy Markdown
Member

I am not sure if it is worth to backport this.

@StanFromIreland
StanFromIreland deleted the unicodetata-bidis branch February 18, 2026 10:59
@StanFromIreland

StanFromIreland commented Feb 18, 2026

Copy link
Copy Markdown
Member Author

Sorry, I don't have time for a true review. From a casual look, this LGTM, though.

No worries, thanks for the reviews.

I am not sure if it is worth to backport this.

Yes, I would think it is an uncommon issue.

brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
@StanFromIreland @brijkapadia
pythongh-142224: unicodedata: support bidi classes for unassigned cod…
80e9d32 
…e points (pythonGH-144815)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@StanFromIreland @ljfp
pythongh-142224: unicodedata: support bidi classes for unassigned cod…
26586b9 
…e points (pythonGH-144815)
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 15, 2026
encukou added a commit to encukou/cpython that referenced this pull request Aug 18, 2026
@encukou
Re-add test from pythonGH-144815
ff4f6df
@encukou encukou mentioned this pull request Aug 18, 2026
Merged
encukou added a commit that referenced this pull request Sep 4, 2026
@encukou @sethmlarson @StanFromIreland
[3.14] gh-155292: Don't consider Unicode codepoint attributes outside…
1e54caa 
… RFC 3454 (GH-155293) (GH-156020)

Due to a bug, some Unicode codepoint attributes were considered
for characters not yet defined in Unicode 3.2.0 or attributes
which changed in later Unicode versions. RFC 3454 (StringPrep)
requires using Unicode 3.2.0 strictly.

(cherry picked from commit 7e109d0)
The cherry-pick needed reworking as GH-144815 wasn't backported to 3.14
and below, so unassigned characters don't have bidi values.

Co-authored-by: Seth Larson <seth@python.org>
Co-authored-by: Stan Ulbrych <89152624+stanfromireland@users.noreply.github.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@miss-islington miss-islington mentioned this pull request Sep 4, 2026
Open
This was referenced Sep 4, 2026
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@benjaminp benjaminp Awaiting requested review from benjaminp
@malemburg malemburg Awaiting requested review from malemburg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @malemburg @serhiy-storchaka