gh-127636: Fix tarfile extracting trailing slash member names - #152984
Merged
Conversation
|
All commit authors signed the Contributor License Agreement. |
Note that './mydir/' is a regular-file member, not DIRTYPE, so a future reader does not turn it into a directory and lose the regression coverage. Also assert the member actually extracts as a file rather than only checking that extract() does not raise.
gpshead
enabled auto-merge (squash)
September 8, 2026 04:01
|
GH-157167 is a backport of this pull request to the 3.15 branch. |
|
GH-157168 is a backport of this pull request to the 3.14 branch. |
|
GH-157169 is a backport of this pull request to the 3.13 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #127636.
Member lookup now tries the exact archive name first and retains the trailing-slash-stripped lookup as a fallback. This allows names returned by
getnames()to be passed toextract()while keeping the previous fallback.