Skip to content

gh-142349: Document LazyImportType.resolve() method #156936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Viicos wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

gh-142349: Document LazyImportType.resolve() method #156936

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Doc/library/types.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,10 @@ Standard names are defined for the following types:

.. seealso:: :pep:`810`

.. method:: resolve()

Resolve the lazy object by reifying the lazily imported module.

@encukou encukou Sep 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at it again, this should mention the return value. Maybe like this:

Suggested change
Resolve the lazy object by reifying the lazily imported module.
Resolve the lazy import and return the "real" imported module.

@johnslavik johnslavik Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would perhaps also be nice to define reifying/resolving "fully" (with all the effects of reifying a lazy import, such as what it does to sys.lazy_modules), but I assume that the spec will do a better job at it.

@Viicos Viicos Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would perhaps also be nice to define reifying/resolving "fully" (with all the effects of reifying a lazy import, such as what it does to sys.lazy_modules), but I assume that the spec will do a better job at it.

Yeah most likely it makes more sense to wait for the full spec to be written out, and update this with a :ref: to what reifying means.

Resolve the lazy import and return the "real" imported module.

lazy proxy objects aren't necessarily proxying module objects, so maybe something like:

Suggested change
Resolve the lazy object by reifying the lazily imported module.
Reify the lazy import and return the "real" object being imported.



.. class:: GetSetDescriptorType

Expand Down
Loading