Skip to content

bpo-41355: Raise if os.link is used with 'follow_symlinks=False' and linkat() is not available #21648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pablogsal wants to merge 1 commit into from
Closed

bpo-41355: Raise if os.link is used with 'follow_symlinks=False' and linkat() is not available #21648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2020-07-28-00-24-01.bpo-41355.lP79Zq.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
The function :func:`os.link` noq raises if *follow_symlinks* is ``False``
and the :c:func:`linkat` function is not available on the platform. Patch
by Pablo Galindo.
3 changes: 3 additions & 0 deletions Modules/posixmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3731,6 +3731,9 @@ os_link_impl(PyObject *module, path_t *src, path_t *dst, int src_dir_fd,
if ((src_dir_fd != DEFAULT_DIR_FD) || (dst_dir_fd != DEFAULT_DIR_FD)) {
argument_unavailable_error("link", "src_dir_fd and dst_dir_fd");
return NULL;
} else if (!follow_symlinks) {
argument_unavailable_error("link", "follow_symlinks");
return NULL;
}
#endif

Expand Down