gh-83245: Raise BadZipFile instead of ValueError when reading a corrupt file - #32291
Merged
Conversation
iritkatriel
reviewed
Apr 4, 2022
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
MaxwellDupre
approved these changes
Apr 23, 2022
MaxwellDupre
left a comment
Contributor
There was a problem hiding this comment.
Ran 258 tests in 59.938s
OK (skipped=1)
Looks ok.
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
LGTM in general, but I have few nitpicks.
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
approved these changes
May 23, 2022
Contributor
|
Thanks @dignissimus for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Contributor
|
Thanks @dignissimus for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-93140 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 23, 2022
… corrupt ZIP file (pythonGH-32291) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> (cherry picked from commit 202ed25) Co-authored-by: Sam Ezeh <sam.z.ezeh@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 23, 2022
… corrupt ZIP file (pythonGH-32291) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> (cherry picked from commit 202ed25) Co-authored-by: Sam Ezeh <sam.z.ezeh@gmail.com>
|
GH-93141 is a backport of this pull request to the 3.11 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #30863
https://bugs.python.org/issue39064