Skip to content

gh-91915: Fix test_netrc on non-UTF-8 locale - #91918

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:test_netrc
Apr 26, 2022
Merged

gh-91915: Fix test_netrc on non-UTF-8 locale#91918
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:test_netrc

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Apr 25, 2022

Copy link
Copy Markdown
Member

Closes #91915.

@serhiy-storchaka
serhiy-storchaka merged commit 36306cf into python:main Apr 26, 2022
@miss-islington

miss-islington commented Apr 26, 2022

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Apr 26, 2022

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 36306cf7862097318a3fef74224075cc4cf37229 3.10

@miss-islington

miss-islington commented Apr 26, 2022

Copy link
Copy Markdown
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 36306cf7862097318a3fef74224075cc4cf37229 3.9

@serhiy-storchaka
serhiy-storchaka deleted the test_netrc branch April 26, 2022 05:01
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Apr 26, 2022
@serhiy-storchaka
[3.10] pythongh-91915: Fix test_netrc on non-UTF-8 locale (pythonGH-9…
cffd470 
…1918).

(cherry picked from commit 36306cf)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

bedevere-bot commented Apr 26, 2022

Copy link
Copy Markdown

GH-91946 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Apr 26, 2022
@serhiy-storchaka serhiy-storchaka removed their assignment Apr 26, 2022
serhiy-storchaka added a commit that referenced this pull request Apr 26, 2022
@serhiy-storchaka
[3.10] gh-91915: Fix test_netrc on non-UTF-8 locale (GH-91918). (GH-9…
dbe666d 
…1946)

(cherry picked from commit 36306cf)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_netrc fails on non-UTF-8 locale

3 participants

@serhiy-storchaka @miss-islington @bedevere-bot