docs: typing.Self, fix typo - #94771
Merged
Fidget-Spinner merged 3 commits intoJul 12, 2022
Merged
Conversation
maxzhenzhera
requested review from
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
July 12, 2022 09:48
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Fidget-Spinner
approved these changes
Jul 12, 2022
Member
|
Could you update https://github.com/python/cpython/blob/main/Lib/typing.py#L572 too please? |
Contributor
Author
|
@Fidget-Spinner Oh, sorry, Didn't think about this. |
Contributor
|
Thanks @maxzhenzhera for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 12, 2022
* fix typo - double spelled word 'use' * change methods names to the infinitive form (cherry picked from commit 90a6e56) Co-authored-by: Max Zhenzhera <59729293+maxzhenzhera@users.noreply.github.com>
|
GH-94786 is a backport of this pull request to the 3.11 branch. |
Member
|
@maxzhenzhera congrats on your first contribution to CPython! Looking forward to more contributions in the future. |
gvanrossum
removed their request for review
July 12, 2022 17:49
miss-islington
added a commit
that referenced
this pull request
Jul 12, 2022
* fix typo - double spelled word 'use' * change methods names to the infinitive form (cherry picked from commit 90a6e56) Co-authored-by: Max Zhenzhera <59729293+maxzhenzhera@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple typo fixes, no issue was created.