feat: __repr__ method for RefExpr and NameExpr
#19486
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addition of these 2 simple reprs was helpful for me for debugging a compiler issue locally
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of these 2 simple reprs was helpful for me for debugging a mypyc compilation issue locally
There's still a bug in the compiler, but I was able to figure out which var(s) were problematic and implement a hacky fix within my own codebase. I'd like to contribute them to the repo to help other people in similar situations in the future.
I don't have enough knowledge of mypyc internals to be of more help in this case. Perhaps this PR will enable a future developer to fix the root cause.