Fix #19491, crash when using enable_error_code value of wrong type in pyproject.toml #19494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
sterliakov
reviewed
Jul 25, 2025
| elif isinstance(v, Sequence): | ||
| return [p.strip() if isinstance(p, str) else p for p in v] | ||
| else: | ||
| return v |
There was a problem hiding this comment.
To keep the blast radius minimal, maybe
Suggested change
| return v | |
| raise argparse.ArgumentTypeError(f"Expected a list or a stringified version thereof, but got: '{v}'") |
There was a problem hiding this comment.
Then you won't need Any in return type too
There was a problem hiding this comment.
A fine suggestion! If we're going this route with it, I can also check the type in the list comprehension as well.
There was a problem hiding this comment.
Config validation is always helpful, let's try to do such easy checks to avoid crashes down the road. It isn't performance-critical (we only check a handful of items and only do that once per run) so shouldn't do any harm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19491
If you give a string in toml, you get Invalid error code(s): whatever. However, if you give a value that doesn't mean a string in toml, you get a crash like TypeError: 'int' object is not iterable.
I suspect this would also apply to many other pyproject.toml values if you set them wrong, because we pass many of them immediately into try_split, which tries to iterate them.
I have added a (fairly minimal) test for this behavior.