Micro-optimize cache primitives in librt.internal #20194
+514
−275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only one of these works at runtime, however.
Collaborator
Author
|
Compiled mypy is expected to fail in CI, since we need to publish a new version of |
ilevkivskyi
approved these changes
Nov 7, 2025
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
LG, thanks! Just few minor things. I think it is fine to break CI for short time. It would be good to fix it before weekend (there may be some contributors who may be confused by the failure).
| @@ -1,19 +1,27 @@ | |||
| from mypy_extensions import u8 | |||
|
|
|||
| # TODO: Remove Buffer -- right now we have hacky support for BOTH the old and new APIs | |||
Member
There was a problem hiding this comment.
When will we be able to remove it? Right after the new version of librt is published, right?
| with assertRaises(ValueError): | ||
| read_int(r) | ||
|
|
||
| def test_buffer_primitive_types() -> None: |
Member
There was a problem hiding this comment.
You forgot to add calls to this tests, and to the two tests below (you only added test_buffer_grow()).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the following optimizations:
This improves the performance of a micro-benchmark that reads integers in a loop by 5%, but this could help more if we'd inline some of the smaller functions (in the future). By making the functions simpler, inlining is more feasible.
I'm not sure what's the best way to merge this -- maybe we'll need to have broken master for a while, and then we ca publish a new version of
librt, and then update mypy to work using the newlibrtversion.