Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PR preview links #215

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Fix PR preview links #215

merged 1 commit into from
Jan 26, 2025

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 26, 2025

This file was copied from CPython and I forgot to remove the paths restriction, and it's never run:

https://github.com/python/python-docs-theme/actions/workflows/documentation-links.yml

We always build a preview here, so let's always add the link.

@AA-Turner AA-Turner merged commit 3d34296 into python:main Jan 26, 2025
14 checks passed
@hugovk hugovk deleted the documentation-links branch January 26, 2025 18:56
@humitos
Copy link

humitos commented Jan 27, 2025

I just saw this issue and I wanted to let you know that we are working on two features related to this that we hope it's gonna make the review process a lot easier.

@hugovk
Copy link
Member Author

hugovk commented Jan 27, 2025

They look great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants