-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add 3.14 Deprecations #14289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
max-muoto
wants to merge
22
commits into
python:main
Choose a base branch
from
max-muoto:add-3.14-deprecations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add 3.14 Deprecations #14289
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
87447ec
Add 3.14 deprecations
max-muoto 2e34041
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c52f786
Fix
max-muoto 7b92886
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5c5315a
Fixes
max-muoto 74badea
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0f14bad
Revert
max-muoto da6d451
Fix
max-muoto 6661c35
Revert
max-muoto 1e2e617
Fix
max-muoto ed65903
Fix
max-muoto 2bffae4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 647bb88
Address comments
max-muoto d40fc6c
Fix
max-muoto 83efd5d
revert
max-muoto 90c97d4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7eccbac
Add override
max-muoto 4f5c981
Fix tests
max-muoto 28a1743
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3de835b
Tweaks
max-muoto 8c44563
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 94c49d6
3.13
max-muoto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,47 @@ | ||
from __future__ import annotations | ||
|
||
import inspect | ||
from asyncio import iscoroutinefunction | ||
from collections.abc import Awaitable, Callable, Coroutine | ||
from types import CoroutineType | ||
from typing import Any | ||
from typing_extensions import assert_type | ||
|
||
|
||
def test_iscoroutinefunction( | ||
def test_iscoroutinefunction_asyncio( | ||
x: Callable[[str, int], Coroutine[str, int, bytes]], | ||
y: Callable[[str, int], Awaitable[bytes]], | ||
z: Callable[[str, int], str | Awaitable[bytes]], | ||
xx: object, | ||
) -> None: | ||
if iscoroutinefunction(x): | ||
# Type ignores are neeeded due to deprecation of iscoroutinefunction in 3.14 | ||
if iscoroutinefunction(x): # type: ignore | ||
assert_type(x, Callable[[str, int], Coroutine[str, int, bytes]]) | ||
|
||
if iscoroutinefunction(y): | ||
if iscoroutinefunction(y): # type: ignore | ||
assert_type(y, Callable[[str, int], Coroutine[Any, Any, bytes]]) | ||
|
||
if iscoroutinefunction(z): | ||
if iscoroutinefunction(z): # type: ignore | ||
assert_type(z, Callable[[str, int], Coroutine[Any, Any, Any]]) | ||
|
||
if iscoroutinefunction(xx): | ||
if iscoroutinefunction(xx): # type: ignore | ||
assert_type(xx, Callable[..., Coroutine[Any, Any, Any]]) | ||
|
||
|
||
def test_iscoroutinefunction_inspect( | ||
x: Callable[[str, int], Coroutine[str, int, bytes]], | ||
y: Callable[[str, int], Awaitable[bytes]], | ||
z: Callable[[str, int], str | Awaitable[bytes]], | ||
xx: object, | ||
) -> None: | ||
if inspect.iscoroutinefunction(x): | ||
assert_type(x, Callable[[str, int], Coroutine[str, int, bytes]]) | ||
|
||
if inspect.iscoroutinefunction(y): | ||
assert_type(y, Callable[[str, int], CoroutineType[Any, Any, bytes]]) | ||
|
||
if inspect.iscoroutinefunction(z): | ||
assert_type(z, Callable[[str, int], CoroutineType[Any, Any, Any]]) | ||
|
||
if inspect.iscoroutinefunction(xx): | ||
assert_type(xx, Callable[..., CoroutineType[Any, Any, Any]]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.13 due as -
The low overhead dynamic frame locals access added in Python 3.13 by PEP 667 means the frame locals cache reference previously stored in this attribute is no longer needed. Derived debuggers should access pdb.Pdb.curframe.f_locals directly in Python 3.13 and later versions
.