Skip to content

Job Posting Section #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Astraxx04
Copy link
Contributor

@Astraxx04 Astraxx04 commented Jun 6, 2025

This PR covers Job Posting Section #113

  • Created Job posting page
  • Created Job Board rules and guidelines page
  • Edited the Button component to use purple_bg as well

Copy link

netlify bot commented Jun 6, 2025

Deploy Preview for inpycon2025 ready!

Name Link
🔨 Latest commit f3f9930
🔍 Latest deploy log https://app.netlify.com/projects/inpycon2025/deploys/68660396d1ccf800085d5bb0
😎 Deploy Preview https://deploy-preview-120--inpycon2025.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Astraxx04
Copy link
Contributor Author

@farhaanbukhsh @anistark @ashish10677 Need few details to complete this:

  1. A Google form link to accept Job Postings.
  2. Which navbar menu will these come under?

@ashish10677
Copy link
Contributor

  1. You can skip that for the time being. We can update when we have it.
  2. It was under About last year. Let's keep it the same. Ref: https://in.pycon.org/2024/

@Astraxx04

@anistark
Copy link
Member

anistark commented Jun 9, 2025

On smaller screen, the view needs fixing:

Screenshot 2025-06-09 at 9 52 36 PM

Maybe try white text color for darker background:

Screenshot 2025-06-09 at 9 53 09 PM

The header part keep in separate color as rest of pages and make the Job Board text larger:

Screenshot 2025-06-09 at 9 53 36 PM

Also, need to fix the image assets that's broken right now.

Copy link
Contributor

@farhaanbukhsh farhaanbukhsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added few nits

@Astraxx04 Astraxx04 force-pushed the job_board_section branch 2 times, most recently from 75b3917 to 043b0fb Compare June 14, 2025 17:47
@Astraxx04
Copy link
Contributor Author

@anistark
I tried with white font-color, didn't look that great.
Screenshot 2025-06-14 at 10 49 12 PM

@anistark @farhaanbukhsh @ashish10677
Please do take a look at how the data is being fetched, we could probably put the sheet_id in env. The only problem is as I've mentioned above, It updates only when it's rebuilt. There might be an other approach where in we can just pass a div when the site is built, and later fetch and render data through browser. The one I've done now was the easier approach. Please lmk what you think

@Astraxx04 Astraxx04 force-pushed the job_board_section branch 2 times, most recently from 7f13fb7 to 01f8728 Compare June 15, 2025 15:16
@anistark
Copy link
Member

@anistark @farhaanbukhsh @ashish10677 Please do take a look at how the data is being fetched, we could probably put the sheet_id in env. The only problem is as I've mentioned above, It updates only when it's rebuilt. There might be an other approach where in we can just pass a div when the site is built, and later fetch and render data through browser. The one I've done now was the easier approach. Please lmk what you think

So, new data is being fetched at deploy time only? Not on every refresh?

@farhaanbukhsh
Copy link
Contributor

@Astraxx04 there should be a way to make the ajax call on refresh, right now the thing this you are exposing this function on build and it sets the data on build as well we need to change that. We need to do ajax call here.

@Astraxx04
Copy link
Contributor Author

@anistark @farhaanbukhsh @ashish10677 Please do take a look at how the data is being fetched, we could probably put the sheet_id in env. The only problem is as I've mentioned above, It updates only when it's rebuilt. There might be an other approach where in we can just pass a div when the site is built, and later fetch and render data through browser. The one I've done now was the easier approach. Please lmk what you think

So, new data is being fetched at deploy time only? Not on every refresh?

Yes. Right now the data is fetched only at deployment

@Astraxx04
Copy link
Contributor Author

@Astraxx04 there should be a way to make the ajax call on refresh, right now the thing this you are exposing this function on build and it sets the data on build as well we need to change that. We need to do ajax call here.

Yes. I will look into this.

@Astraxx04 Astraxx04 force-pushed the job_board_section branch 4 times, most recently from be7a589 to 3870738 Compare June 20, 2025 17:30
@Astraxx04 Astraxx04 closed this Jun 20, 2025
@Astraxx04 Astraxx04 force-pushed the job_board_section branch from 3870738 to 0d611aa Compare June 20, 2025 17:44
@Astraxx04 Astraxx04 reopened this Jun 20, 2025
@Astraxx04
Copy link
Contributor Author

@farhaanbukhsh @anistark @ashish10677 Made the changes. Made it a async. Do take a look

@Astraxx04 Astraxx04 force-pushed the job_board_section branch from 7224869 to 1fb035f Compare June 24, 2025 17:22
Copy link
Member

@anistark anistark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anistark
Copy link
Member

@farhaanbukhsh we need the right google form and sheet to be updated before merging this.

Currently blocked on it.

@farhaanbukhsh
Copy link
Contributor

@Astraxx04 what is required to get this merged?

@Astraxx04
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants