-
Notifications
You must be signed in to change notification settings - Fork 19
Job Posting Section #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Job Posting Section #120
Conversation
✅ Deploy Preview for inpycon2025 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@farhaanbukhsh @anistark @ashish10677 Need few details to complete this:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added few nits
75b3917
to
043b0fb
Compare
@anistark @anistark @farhaanbukhsh @ashish10677 |
7f13fb7
to
01f8728
Compare
So, new data is being fetched at deploy time only? Not on every refresh? |
@Astraxx04 there should be a way to make the ajax call on refresh, right now the thing this you are exposing this function on build and it sets the data on build as well we need to change that. We need to do ajax call here. |
Yes. Right now the data is fetched only at deployment |
Yes. I will look into this. |
be7a589
to
3870738
Compare
3870738
to
0d611aa
Compare
@farhaanbukhsh @anistark @ashish10677 Made the changes. Made it a async. Do take a look |
7224869
to
1fb035f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@farhaanbukhsh we need the right google form and sheet to be updated before merging this. Currently blocked on it. |
@Astraxx04 what is required to get this merged? |
@farhaanbukhsh a Google form and sheet. |
This PR covers Job Posting Section #113