-
Notifications
You must be signed in to change notification settings - Fork 22
Change conference name from multi-lingual field to CharField #4462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Convert Conference.name from I18nCharField to models.CharField - Remove unused I18nCharField import from conference model - Create migration 0055 to handle database schema change - Update GraphQL Conference type to use regular field instead of localized resolver Fixes #4066 Co-authored-by: Marco Acierno <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@claude there are a few places where we do |
Claude finished @marcoacierno's task —— View job Finding and fixing conference.name.localize() calls ✅
Completed! Found and updated 25 instances across 11 files:
All instances of |
- Replace conference.name.localize(language_code) with direct conference.name usage - Updated 25 instances across 11 files in backend codebase - Conference name is now a regular CharField, no longer needs localization Co-authored-by: Marco Acierno <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4462 +/- ##
=======================================
Coverage ? 94.53%
=======================================
Files ? 352
Lines ? 10131
Branches ? 733
=======================================
Hits ? 9577
Misses ? 461
Partials ? 93 🚀 New features to boost your workflow:
|
@claude We likely need to update the ConferenceFactory as well to not set |
Claude encountered an error —— View job Updating ConferenceFactory to use CharField
Updated ConferenceFactory and test:
Committing changes... |
Co-authored-by: Marco Acierno <[email protected]>
Convert Conference.name from I18nCharField to models.CharField
Changes
Closes #4066
Generated with Claude Code