Handle fetch optimizer states for the KV ZCH load state dict case #4512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D77771359 |
Summary: X-link: facebookresearch/FBGEMM#1561 This diff updates `KVZCHCachedData` to hold multiple optimizer states per table in cached_optimizer_states_per_table, and updates apply_state_dict to handle writing out multiple optimizer states per table row to the cache. This is needed for enabling other optimizers to work with SSD TBE, such as Partial Rowwise Adam. There are 4 cases to handle when attempting to fetch the split optimizer states: 1. The no-KV ZCH case 1. The KV ZCH case, but where `self.load_state_dict` is `True` (i.e. fall back to `self._cached_kvzch_data`) 1. The KV ZCH case, where `self.load_state_dict` is `False`, and `self.enable_optimizer_offloading` is false 1. The KV ZCH case, where `self.load_state_dict` is `False`, and `self.enable_optimizer_offloading` is `True` The diff completes the handling of returning optimizer states for the KV ZCH case, but where `self.load_state_dict` is true (case 2). Reviewed By: emlin Differential Revision: D77771359
|
This pull request was exported from Phabricator. Differential Revision: D77771359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff updates
KVZCHCachedDatato hold multiple optimizer states per table in cached_optimizer_states_per_table, and updates apply_state_dict to handle writing out multiple optimizer states per table row to the cache. This is needed for enabling other optimizers to work with SSD TBE, such as Partial Rowwise Adam.There are 4 cases to handle when attempting to fetch the split optimizer states:
self.load_state_dictisTrue(i.e. fall back toself._cached_kvzch_data)self.load_state_dictisFalse, andself.enable_optimizer_offloadingis falseself.load_state_dictisFalse, andself.enable_optimizer_offloadingisTrueThe diff completes the handling of returning optimizer states for the KV ZCH case, but where
self.load_state_dictis true (case 2).Reviewed By: emlin
Differential Revision: D77771359