-
Notifications
You must be signed in to change notification settings - Fork 617
[FBGEMM] Modularize FBGEMM CMake Target Definitions, pt 3b #4524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2d2de86
to
a6184c2
Compare
In PT we use the Sanitizer::address and other similar targets for sanitizers, which are more accurate. Therefore should we check the existence of these targets and prefer them? |
f54d31a
to
752294e
Compare
-Wno-infinite-recursion | ||
-Wno-sign-compare | ||
-Wno-gnu-zero-variadic-macro-arguments | ||
-Wno-unused-parameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can enable -Wunused-parameter
, the code is clean enough to support it.
cmake/modules/CppLibrary.cmake
Outdated
if(CMAKE_COMPILER_IS_GNUCXX AND (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 8.3.0)) | ||
# Workaround for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80947 | ||
list(APPEND lib_cc_flags | ||
-Wno-attributes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we really support old g++? Is it for META builds? but how can they build C++20 code?
Some disabled |
One more concern: we use cpuinfo for runtime CPU architecture detection; meanwhile we also use conditional preprocessing inclusion for build time CPU architecture, are the actions conflicting? |
32d9fc3
to
b83aa34
Compare
b83aa34
to
47fb27a
Compare
47fb27a
to
d89366e
Compare
No description provided.