[FBGEMM] Modularize FBGEMM CMake Target Definitions, pt 3b #4524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
q10
changed the title
q10
force-pushed
the
bm/fbgemm-arm-build-3
branch
2 times, most recently
from
2d2de86 to
a6184c2
Compare
|
In PT we use the Sanitizer::address and other similar targets for sanitizers, which are more accurate. Therefore should we check the existence of these targets and prefer them? |
q10
force-pushed
the
bm/fbgemm-arm-build-3
branch
2 times, most recently
from
f54d31a to
752294e
Compare
cyyever
approved these changes
Jul 22, 2025
cmake/modules/CppLibrary.cmake
Outdated
| -Wno-infinite-recursion | ||
| -Wno-sign-compare | ||
| -Wno-gnu-zero-variadic-macro-arguments | ||
| -Wno-unused-parameter |
There was a problem hiding this comment.
We can enable -Wunused-parameter, the code is clean enough to support it.
|
Some disabled |
|
One more concern: we use cpuinfo for runtime CPU architecture detection; meanwhile we also use conditional preprocessing inclusion for build time CPU architecture, are the actions conflicting? |
q10
force-pushed
the
bm/fbgemm-arm-build-3
branch
3 times, most recently
from
32d9fc3 to
b83aa34
Compare
q10
changed the title
q10
force-pushed
the
bm/fbgemm-arm-build-3
branch
2 times, most recently
from
47fb27a to
d89366e
Compare
q10
force-pushed
the
bm/fbgemm-arm-build-3
branch
3 times, most recently
from
4555869 to
9f9d628
Compare
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 26, 2025
Summary: X-link: facebookresearch/FBGEMM#1623 Differential Revision: D79026340 Pulled By: q10
q10
force-pushed
the
bm/fbgemm-arm-build-3
branch
from
9f9d628 to
036c5b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79026340 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 26, 2025
Summary: X-link: facebookresearch/FBGEMM#1623 Differential Revision: D79026340 Pulled By: q10
q10
force-pushed
the
bm/fbgemm-arm-build-3
branch
from
036c5b2 to
b36f068
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79026340 |
q10
force-pushed
the
bm/fbgemm-arm-build-3
branch
from
b36f068 to
bb69c22
Compare
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jul 26, 2025
Summary: X-link: facebookresearch/FBGEMM#1623 Reviewed By: cthi Differential Revision: D79026340 Pulled By: q10
|
This pull request was exported from Phabricator. Differential Revision: D79026340 |
Summary: X-link: facebookresearch/FBGEMM#1623 Reviewed By: cthi Differential Revision: D79026340 Pulled By: q10
q10
force-pushed
the
bm/fbgemm-arm-build-3
branch
from
bb69c22 to
3e2b125
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79026340 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.