-
Notifications
You must be signed in to change notification settings - Fork 619
[FBGEMM] Modularize FBGEMM CMake Target Definitions, pt 3b #4524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2d2de86
to
a6184c2
Compare
In PT we use the Sanitizer::address and other similar targets for sanitizers, which are more accurate. Therefore should we check the existence of these targets and prefer them? |
f54d31a
to
752294e
Compare
cmake/modules/CppLibrary.cmake
Outdated
-Wno-infinite-recursion | ||
-Wno-sign-compare | ||
-Wno-gnu-zero-variadic-macro-arguments | ||
-Wno-unused-parameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can enable -Wunused-parameter
, the code is clean enough to support it.
Some disabled |
One more concern: we use cpuinfo for runtime CPU architecture detection; meanwhile we also use conditional preprocessing inclusion for build time CPU architecture, are the actions conflicting? |
32d9fc3
to
b83aa34
Compare
47fb27a
to
d89366e
Compare
4555869
to
9f9d628
Compare
Summary: X-link: facebookresearch/FBGEMM#1623 Differential Revision: D79026340 Pulled By: q10
9f9d628
to
036c5b2
Compare
This pull request was exported from Phabricator. Differential Revision: D79026340 |
Summary: X-link: facebookresearch/FBGEMM#1623 Differential Revision: D79026340 Pulled By: q10
036c5b2
to
b36f068
Compare
This pull request was exported from Phabricator. Differential Revision: D79026340 |
b36f068
to
bb69c22
Compare
Summary: X-link: facebookresearch/FBGEMM#1623 Reviewed By: cthi Differential Revision: D79026340 Pulled By: q10
This pull request was exported from Phabricator. Differential Revision: D79026340 |
Summary: X-link: facebookresearch/FBGEMM#1623 Reviewed By: cthi Differential Revision: D79026340 Pulled By: q10
bb69c22
to
3e2b125
Compare
This pull request was exported from Phabricator. Differential Revision: D79026340 |
No description provided.