Skip to content

Various fixes #4529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Various fixes #4529

wants to merge 20 commits into from
+73 −107

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Jul 21, 2025

No description provided.

@netlify Netlify
Copy link

netlify bot commented Jul 21, 2025 •
edited
Loading

✅ Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 17ad443
🔍 Latest deploy log https://app.netlify.com/projects/pytorch-fbgemm-docs/deploys/687f429dea66d500088e6c95
😎 Deploy Preview https://deploy-preview-4529--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@meta-cla meta-cla bot added the cla signed label Jul 21, 2025
@cyyever cyyever changed the title No nan Various fixes Jul 21, 2025
@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this in D78675482.

@q10
Copy link
Contributor

q10 commented Jul 21, 2025

@cyyever Some static asserts appear to be failing

cyyever added 16 commits July 22, 2025 10:48
@cyyever
Avoid NAN initialization
1801b68 
Signed-off-by: cyy <[email protected]>
@cyyever
Use static_assert
0c2f186 
Signed-off-by: cyy <[email protected]>
@cyyever
Use static_assert
17c513a 
Signed-off-by: cyy <[email protected]>
@cyyever
Use static_assert
e028dbf 
Signed-off-by: cyy <[email protected]>
@cyyever
Use static_assert
d6bda50 
Signed-off-by: cyy <[email protected]>
@cyyever
Use maybe_unused
9a5bc43 
Signed-off-by: cyy <[email protected]>
@cyyever
Use if constexpr
a4306f4 
Signed-off-by: cyy <[email protected]>
@cyyever
Fix multiple declarations
54c5a43 
Signed-off-by: cyy <[email protected]>
@cyyever
Exchange num_threads and thread_id in fbgemmGetThreadPartition declar…
70383b8 
…ation due to implementation

Signed-off-by: cyy <[email protected]>
@cyyever
Reduce variable range
b0d7c9b 
Signed-off-by: cyy <[email protected]>
@cyyever
Use constexpr
1e5b5ed 
Signed-off-by: cyy <[email protected]>
@cyyever
Narrow variables
3377e20 
Signed-off-by: cyy <[email protected]>
@cyyever
Narrow variables
c868205 
Signed-off-by: cyy <[email protected]>
@cyyever
Narrow variables
e41b948 
Signed-off-by: cyy <[email protected]>
@cyyever
Enable more checks
bf255df 
Signed-off-by: cyy <[email protected]>
@cyyever
Fix build errors
5e23ec8 
Signed-off-by: cyy <[email protected]>
@cyyever
Copy link
Contributor Author

cyyever commented Jul 22, 2025

@q10 Fixed.

@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this in D78675482.

@cyyever
Copy link
Contributor Author

cyyever commented Jul 22, 2025 •
edited
Loading

@q10 The new failures are for reinterpret_cast pointers. We could use std::bit_cast in C++20, but due to varying standard support of different compiler versions they are reverted.

@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this in D78675482.

@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this in D78675482.

@q10
Copy link
Contributor

q10 commented Jul 22, 2025

@cyyever I64Test appears to be failing

@cyyever
Copy link
Contributor Author

cyyever commented Jul 22, 2025

@q10 I see, I'm running UBSAN locally to find more info.

@cyyever
Copy link
Contributor Author

cyyever commented Jul 22, 2025

@q10 Fixed

@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this in D78675482.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyyever @facebook-github-bot @q10