Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: This pull request introduces support for AMD MI355x GPUs with HIPBLASLT kernels in the MX formats prototype. Note that this feature requires ROCm 6.5+ and gfx950
alongside several updates to improve compatibility and functionality for these GPUs. Key changes include updates to configuration options, validation logic, and GEMM kernel handling to integrate HIPBLASLT support.
AMD MI355x GPU Support:
torchao/prototype/mx_formats/config.py
:HIPBLASLT
as a newMXGemmKernelChoice
and included it in theMXLinearRecipeName
for configuration presets. [1] [2]_validate_gemm_kernel_choice
to include validation logic forHIPBLASLT
, ensuring proper block size, data type, and ROCm availability.torchao/prototype/mx_formats/mx_ops.py
:mx_mm
to supportHIPBLASLT
for scaled matrix multiplication and real GEMM operations. [1] [2]Documentation Updates:
torchao/prototype/mx_formats/README.md
:Minor Code Refinements:
torchao/prototype/mx_formats/mx_ops.py
:mx_view_op
by reformatting conditions for FP6 element packing.