Skip to content

Add pct_achievable_gemm_tops and pct_achievable_mem_bw to fp8 roofline utils #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mreso
Copy link
Contributor

@mreso mreso commented Apr 23, 2025

This PR adds pct_achievable_gemm_tops and pct_achievable_mem_bw to fp8 roofline utils.

The values were determined through microbenchmarking and match previously published values.

Copy link

pytorch-bot bot commented Apr 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2120

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8c19743 with merge base a37f4e4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2025
@mreso mreso added benchmark topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) labels Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants